Np mj sort items soon integers #66
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-collab-lab/tcl-3-smart-shopping-list into aj-mj-add-number-of-purchases
Adding numberofPurchases and lastestInterval to database
… latestInterval variable
…teEstimate function
src/pages/List.js
Outdated
| @@ -38,19 +69,20 @@ const List = props => { | |||
| // Sort the data | |||
| sort="name" | |||
| // Only fetch the items associated with the token saved in localStorage | |||
| filter={['token', '==', token || getCurrentToken() || 'no token set']} | |||
There was a problem hiding this comment.
Careful here @MonicaDJohnson. This is a breaking change when the user doesn't already have a token saved in localStorage. I know this is from the branch this PR is based on, but just a heads up.
src/pages/List.js
Outdated
| @@ -38,19 +69,20 @@ const List = props => { | |||
| // Sort the data | |||
| sort="name" | |||
There was a problem hiding this comment.
What else might you pass here besides name? Are the items always in alphabetical order—why?
mikeramz86
reviewed
Feb 8, 2020
| 'token', | ||
| '==', | ||
| token || getCurrentToken() || 'no token set', | ||
| 'nextExpectedPurchase', |
There was a problem hiding this comment.
@stevelikesmusic I think this is wrong but what I was trying to attempt is to compare nextExpectedPurchase with an integer and if that integer is <= 7 then I want only those items shown.
mikeramz86
reviewed
Feb 8, 2020
| </div> | ||
| <ul className="shopping-list"> | ||
| {shoppingList | ||
| .filter(item => filterListInput(item.name)) |
There was a problem hiding this comment.
@stevelikesmusic can we add the comparison here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.